Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing with Go 1.17 and Terratest 0.39.0 #22

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Testing with Go 1.17 and Terratest 0.39.0 #22

merged 3 commits into from
Mar 3, 2022

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 22, 2022

what && why

  • Update go version use in tests from 1.16 to 1.17 for security fixes
  • Revert terratest from 0.40.0 to 0.39.0 to ensure support for Terraform version < 1.1
  • Update boilerplate to stay current

@Nuru Nuru requested review from a team as code owners February 22, 2022 23:28
@Nuru
Copy link
Contributor Author

Nuru commented Feb 23, 2022

/test all

@Nuru Nuru requested review from a team as code owners February 26, 2022 02:52
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to 6a311f7 - Test enabled=false, run tests in parallel - 1 new error was added

Change details

Error ID Change Path Resource
BC_VUL_2 Added /test/src/go.sum undefined

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to 4d25a05 - Test enabled=false, run tests in parallel - 1 new error was added

Change details

Error ID Change Path Resource
BC_VUL_2 Added /test/src/go.sum undefined

@Nuru
Copy link
Contributor Author

Nuru commented Feb 26, 2022

/test all

Note that the Bridgcrew error BC_VUL_2 is an vulnerability in the go test suite that we do not have a fix for.

@Nuru Nuru merged commit 2860070 into main Mar 3, 2022
@Nuru Nuru deleted the go-1.17 branch March 3, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants