Fix. Ansible provisioner shows pending changes each time. Make `arguments` and `envs` variables not required #14

SweetOps · 2017-10-10T10:28:55Z

What

Ansible provisioner shows pending changes each time
Make arguments and envs variables not required Fix. Ansible provisioner shows pending changes each time. Make arguments and envs variables not required #14

Why

Module shouldn't rerun playbook if nothing has changed
Keep everything DRY

SweetOps · 2017-10-10T10:32:35Z

const-bon · 2017-10-10T16:19:35Z

main.tf

@@ -17,11 +15,11 @@ resource "null_resource" "provisioner" {

  triggers {
    signature = "${data.archive_file.default.output_md5}"
-    command   = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", var.arguments)} -e ${join(" -e ", var.envs)} ${var.playbook}"
+    command   = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${length(compact(concat(var.arguments))) > 0 ? join(" ", var.arguments) : ""} ${length(compact(concat(var.envs))) > 0 ? "-e" : ""} ${length(compact(concat(var.envs))) > 0 ? join(" -e ", var.envs) : ""} ${var.playbook}"


This version is shorter and might be better:

command = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", compact(var.arguments))} ${length(compact(var.envs)) > 0 ? "-e" : ""} ${join(" -e ", concat(var.envs))} ${var.playbook}"

const-bon · 2017-10-10T16:22:01Z

variables.tf

 }

-variable "playbook" {}
+variable "playbook" {
+  default = ""


I assume, empty default value will cause an error.
playbook path is required.

@comeanother, look at count = "${signum(length(var.playbook)) == 1 ? 1 : 0}"

const-bon · 2017-10-10T16:23:23Z

variables.tf

 }

 variable "envs" {
-  type = "list"
+  default = [""]


Let's use empty list [] as default value. Without empty strings.

const-bon · 2017-10-10T16:23:26Z

variables.tf

@@ -1,12 +1,16 @@
 variable "arguments" {
-  type = "list"
+  default = [""]


Let's use empty list [] as default value. Without empty strings.

SweetOps · 2017-10-10T16:32:17Z

osterman · 2017-10-10T19:05:23Z

main.tf

@@ -17,11 +15,11 @@ resource "null_resource" "provisioner" {

  triggers {
    signature = "${data.archive_file.default.output_md5}"
-    command   = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", var.arguments)} -e ${join(" -e ", var.envs)} ${var.playbook}"
+    command   = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", compact(var.arguments))} ${length(compact(var.envs)) > 0 ? "-e" : ""} ${length(compact(var.envs)) > 0 ? join(" -e ", var.envs) : ""} ${var.playbook}"


~~shouldn't there be spaces on either side of the -e like we do in the join?~~

Ah, I see. there are spaces outside of the interpolation.

${length(compact(var.envs)) > 0 ? join(" -e ", var.envs) : ""}
should be
${join(" -e ", compact(var.envs))}

const-bon · 2017-10-12T14:50:55Z

main.tf

@@ -17,11 +15,11 @@ resource "null_resource" "provisioner" {

  triggers {
    signature = "${data.archive_file.default.output_md5}"
-    command   = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", var.arguments)} -e ${join(" -e ", var.envs)} ${var.playbook}"
+    command   = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", compact(var.arguments))} ${length(compact(var.envs)) > 0 ? "-e" : ""} ${length(compact(var.envs)) > 0 ? join(" -e ", var.envs) : ""} ${var.playbook}"


${length(compact(var.envs)) > 0 ? join(" -e ", var.envs) : ""}
should be
${join(" -e ", compact(var.envs))}

const-bon · 2017-10-12T14:51:36Z

main.tf

  }

  provisioner "local-exec" {
-    command = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", var.arguments)} -e ${join(" -e ", var.envs)} ${var.playbook}"
+    command = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", compact(var.arguments))} ${length(compact(var.envs)) > 0 ? "-e" : ""} ${length(compact(var.envs)) > 0 ? join(" -e ", var.envs) : ""} ${var.playbook}"


${length(compact(var.envs)) > 0 ? join(" -e ", var.envs) : ""}
should be
${join(" -e ", compact(var.envs))}

@comeanother , in this case will get the error with empty var.envs

ansible-playbook: error: -e option requires an argument

What would be if var.envs has empty elements like ""?
I assume, ansible-playbook command will fail, because it will be like:

ansible-playbook -e -e var=value

look at check conditionlength(compact(var.envs))

Let's consider the following example:

variable envs { default = ["", "TEST=test"] }

It will pass condition check length(compact(var.envs)). but fail later

ansible-playbook -e -e TEST=test

We can't prevent all misstakes. If we add compact() for var.envs - using some vars like "dev=name title" will be impossible.

@osterman, what do you think about that?

For example if use some vars like "name=${some_words}" it'll break module too :) . What check should be added ? :)

${join(" -e ", compact(var.envs))} works properly.

Example:

variable "envs" { default = ["", "test"] } variable "dry_run" { default = "false" } variable "arguments" { default = [] } variable "playbook" { default = "" } output "b" { value = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", compact(var.arguments))} ${length(compact(var.envs)) > 0 ? "-e" : ""} ${length(compact(var.envs)) > 0 ? join(" -e ", var.envs) : ""} ${var.playbook}" } output "c" { value = "ansible-playbook ${var.dry_run ? "--check --diff" : ""} ${join(" ", compact(var.arguments))} ${length(compact(var.envs)) > 0 ? "-e" : ""} ${join(" -e ", compact(var.envs))} ${var.playbook}" }

SweetOps · 2017-10-13T12:42:25Z

const-bon

Secondary terraform apply still shows changes.

const-bon · 2017-10-13T13:29:42Z

Nevermind, I've used wrong branch.

SweetOps added 3 commits October 10, 2017 12:24

fix recreation

4236acd

set default values for arguments and envs

f6735c3

fix checks

87b82e8

SweetOps self-assigned this Oct 10, 2017

SweetOps requested review from osterman and const-bon October 10, 2017 10:28

SweetOps changed the title ~~Fix issue with recreation and set variables arguments, envs to no required~~ Fix issue with recreation and set variables arguments, envs to non-required Oct 10, 2017

const-bon suggested changes Oct 10, 2017

View reviewed changes

changed default values for variables

8f18ceb

removed unusend concat

216d709

osterman reviewed Oct 10, 2017

View reviewed changes

osterman previously approved these changes Oct 10, 2017

View reviewed changes

const-bon suggested changes Oct 12, 2017

View reviewed changes

fix check condition for envs

c8aa004

SweetOps dismissed osterman’s stale review via c8aa004 October 13, 2017 12:40

const-bon suggested changes Oct 13, 2017

View reviewed changes

const-bon approved these changes Oct 13, 2017

View reviewed changes

const-bon changed the title ~~Fix issue with recreation and set variables arguments, envs to non-required~~ Fix. Ansible provisioner shows pending changes each time. Make arguments and envs variables not required Oct 13, 2017

const-bon merged commit 04fb77c into master Oct 13, 2017

const-bon deleted the recreate_fix branch October 13, 2017 13:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix. Ansible provisioner shows pending changes each time. Make `arguments` and `envs` variables not required #14

Fix. Ansible provisioner shows pending changes each time. Make `arguments` and `envs` variables not required #14

SweetOps commented Oct 10, 2017 •

edited by const-bon

Loading

SweetOps commented Oct 10, 2017

const-bon Oct 10, 2017

const-bon Oct 10, 2017

SweetOps Oct 10, 2017

const-bon Oct 10, 2017

const-bon Oct 10, 2017

SweetOps commented Oct 10, 2017

osterman Oct 10, 2017 •

edited

Loading

const-bon Oct 12, 2017

const-bon Oct 12, 2017

const-bon Oct 12, 2017

SweetOps Oct 12, 2017

const-bon Oct 12, 2017

SweetOps Oct 12, 2017

const-bon Oct 12, 2017

SweetOps Oct 12, 2017

SweetOps Oct 12, 2017

SweetOps Oct 12, 2017 •

edited

Loading

const-bon Oct 13, 2017

SweetOps commented Oct 13, 2017

const-bon left a comment

const-bon commented Oct 13, 2017

Fix. Ansible provisioner shows pending changes each time. Make arguments and envs variables not required #14

Fix. Ansible provisioner shows pending changes each time. Make arguments and envs variables not required #14

Conversation

SweetOps commented Oct 10, 2017 • edited by const-bon Loading

What

Why

SweetOps commented Oct 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SweetOps commented Oct 10, 2017

osterman Oct 10, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SweetOps Oct 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SweetOps commented Oct 13, 2017

const-bon left a comment

Choose a reason for hiding this comment

const-bon commented Oct 13, 2017

Fix. Ansible provisioner shows pending changes each time. Make `arguments` and `envs` variables not required #14

Fix. Ansible provisioner shows pending changes each time. Make `arguments` and `envs` variables not required #14

SweetOps commented Oct 10, 2017 •

edited by const-bon

Loading

osterman Oct 10, 2017 •

edited

Loading

SweetOps Oct 12, 2017 •

edited

Loading