chore: Update SDK to v0.14.1 #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
Jul 19, 2022
| }) | ||
| if pCfg != nil && pCfg.Format != cqproto.ConfigYAML { | ||
| if pCfg != nil && pCfg.Format != 1 /* YAML */ { |
There was a problem hiding this comment.
Not sure when we should remove this check
yevgenypats
approved these changes
Jul 20, 2022
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.23](cloudquery/cq-provider-aws@v0.12.22...v0.12.23) (2022-07-03) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.13.1 ([#1127](cloudquery/cq-provider-aws#1127)) ([527a614](cloudquery/cq-provider-aws@527a614)) * Diagnostic blocking Use of Orgs ([#1134](cloudquery/cq-provider-aws#1134)) ([ca6f745](cloudquery/cq-provider-aws@ca6f745)) * **docs:** Update instructions for adding new resources and add install-tools command ([#1128](cloudquery/cq-provider-aws#1128)) ([29ac7d3](cloudquery/cq-provider-aws@29ac7d3)) * Typo in example config ([#1132](cloudquery/cq-provider-aws#1132)) ([2cdebb7](cloudquery/cq-provider-aws@2cdebb7)), closes [#1131](cloudquery/cq-provider-aws#1131) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go with cloudquery/cq-provider-sdk#424
This isn't a breaking change because it's already not supported any more, we're just updating the SDK to remove it almost completely.
Tests won't pass until provider PRs are merged/released because now that the config format flag is gone from the SDK, we can't request yaml config format from the current providers.using 0.14.1 to overcome this issue