feat: Support generic output type #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
approved these changes
Jun 9, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.1...v0.3.0) (2023-06-12) ### ⚠ BREAKING CHANGES * Service per dir ([#6](#6)) * Support multiple clients in the same package ([#5](#5)) ### Features * Service per dir ([#6](#6)) ([12795c8](12795c8)) * Support generic output type ([#1](#1)) ([f8dc681](f8dc681)) * Support multiple clients in the same package ([#5](#5)) ([db0fd3c](db0fd3c)) * Support packages versions greater than v1 ([#4](#4)) ([19193a6](19193a6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling
.String()on an output type of a generic method the resulting string has the full import path.For example without this fix the signature returned for the new test is:
This PR fixes it by normalizing the signature. Happy to get feedback on the solution if there's a better way to do it.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)