Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Lambda function Tags null #1016

Merged
merged 3 commits into from
Jun 8, 2022
Merged

fix: Lambda function Tags null #1016

merged 3 commits into from
Jun 8, 2022

Conversation

roneli
Copy link
Contributor

@roneli roneli commented Jun 7, 2022 •
edited
Loading

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@roneli roneli requested a review from bbernays June 7, 2022 12:05
@roneli roneli requested a review from a team as a code owner June 7, 2022 12:05
bbernays
bbernays suggested changes Jun 7, 2022
View reviewed changes
resources/services/lambda/functions.go Outdated Show resolved Hide resolved
bbernays
bbernays approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the checks all pass

@roneli roneli merged commit 35721ba into cloudquery:main Jun 8, 2022
@roneli roneli deleted the fix-Lambda-function-null-in-tags branch June 8, 2022 08:28
@cq-bot cq-bot mentioned this pull request Jun 8, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 9, 2022
@cq-bot
chore(main): Release v0.12.8 (#1018)
8133f26 
🤖 I have created a release *beep* *boop*
---


## [0.12.8](v0.12.7...v0.12.8) (2022-06-08)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.0 ([#1023](#1023)) ([ae18dbb](ae18dbb))
* Ignore listener certs for gateway listeners ([#1005](#1005)) ([6553c8c](6553c8c))
* Lambda function Tags null ([#1016](#1016)) ([35721ba](35721ba))
* Panic in fetchRdsInstanceDbSubnetGroupSubnets ([#1020](#1020)) ([0aa25cf](0aa25cf))
* Panic in IsInvalidParameterValueError ([#1019](#1019)) ([32df59e](32df59e))
* Update endpoints ([#1025](#1025)) ([bf3e6ec](bf3e6ec))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbernays bbernays bbernays approved these changes

@erezrokah erezrokah erezrokah approved these changes

@shimonp21 shimonp21 shimonp21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roneli @erezrokah @bbernays @shimonp21