fix: Continue fetching on incorrect account permissions

[bbernays]

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

---

Use the following steps to ensure your PR is ready to be reviewed

• Read the contribution guidelines 🧑‍🎓
• Run go fmt to format your code 🖊
• Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
• Update or add tests. Learn more about testing here 🧪
• Update the docs by running go run ./docs/docs.go and committing the changes 📃
• If adding a new resource, add relevant Terraform files in a separate PR 📂
• Ensure the status checks below are successful ✅

[yevgenypats]

Looks good. This code section in general might need additional refactor in the future but for the sake of unblocking this and fixing number of issues that block customers we can push this now.

Just some idea - remove InitServicesForPartitionAccountAndScope as we only need to create aws clients per region per account rather per some parameter - Otherwise we are not alligned with AWS server side throttling mechanism and we will get throttle more.

[disq]

Why the partition business? A credential only be valid in a single partition, no? So why not have the partition as a property in Client and get rid of the additional map levels?

[bbernays]

Why the partition business? A credential only be valid in a single partition, no? So why not have the partition as a property in Client and get rid of the additional map levels?

@disq - We need to store the partition in that serviceregion map because the client.partition field can be overwritten if there are credentials from different partitions

[bbernays]

Looks good. This code section in general might need additional refactor in the future but for the sake of unblocking this and fixing number of issues that block customers we can push this now.

Just some idea - remove InitServicesForPartitionAccountAndScope as we only need to create aws clients per region per account rather per some parameter - Otherwise we are not alligned with AWS server side throttling mechanism and we will get throttle more.

@yevgenypats - Completely agree that more code can be refactored, but was trying to balance changing code with fixing issues. I would not delete InitServicesForPartitionAccountAndScope in this pr as I would want to take a deeper look into that change

[disq]

Looks like Account struct can be removed now, LGTM otherwise

[irmatov]

do we care about duplicates here?

[bbernays]

I don't think an AWS account can span multiple partitions