Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Added lightsail buckets #1097

Merged
merged 12 commits into from
Jul 18, 2022
Merged

feat: Added lightsail buckets #1097

merged 12 commits into from
Jul 18, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Jun 23, 2022 •
edited
Loading

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@amanenk amanenk marked this pull request as ready for review June 23, 2022 19:55
@amanenk amanenk requested a review from a team as a code owner June 23, 2022 19:55
@amanenk amanenk requested review from zagronitay and removed request for a team June 23, 2022 19:55
amanenk added 2 commits July 18, 2022 12:13
@amanenk
Merge branch 'main' into lightsail_bucket
eeebb08 
# Conflicts:
#	client/mocks/mock_lightsail.go
#	go.mod
#	go.sum
#	resources/provider/provider.go
#	resources/services/lightsail/gen.hcl
@amanenk
mock regenerate
eb8e512
@amanenk amanenk requested a review from bbernays July 18, 2022 10:34
hermanschaaf
hermanschaaf approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice addition 👍

resources/services/lightsail/gen.hcl Outdated Show resolved Hide resolved
@amanenk @hermanschaaf
Update resources/services/lightsail/gen.hcl
dabee29 
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
@amanenk amanenk merged commit 74b216a into cloudquery:main Jul 18, 2022
@cq-bot cq-bot mentioned this pull request Jul 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@zagronitay zagronitay Awaiting requested review from zagronitay zagronitay is a code owner automatically assigned from cloudquery/cloudquery-opensource

@bbernays bbernays Awaiting requested review from bbernays

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanenk @hermanschaaf @bbernays