Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

cloudfront distributions regenerated and tags added #207

Merged
merged 13 commits into from
Dec 3, 2021

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Oct 7, 2021

No description provided.

@amanenk amanenk linked an issue Nov 26, 2021 that may be closed by this pull request
@amanenk amanenk marked this pull request as ready for review November 30, 2021 20:18
@amanenk amanenk requested a review from roneli November 30, 2021 20:18
@bbernays bbernays self-requested a review November 30, 2021 21:00
Copy link
Contributor

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, but are we not grabbing any data from GetDistribution as not all information is available from ListDistributions

See this issue: #305

resources/cloudfront_distributions.go Outdated Show resolved Hide resolved
@amanenk
Copy link
Contributor Author

amanenk commented Dec 1, 2021

I have regenerated with GetDistribution result

@amanenk amanenk requested a review from bbernays December 1, 2021 10:59
Copy link
Contributor

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	resources/migrations/8_v0.7.1.down.sql
#	resources/migrations/8_v0.7.1.up.sql
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to drop tables that turned into jsons.

resources/cloudfront_distributions.go Outdated Show resolved Hide resolved
@amanenk amanenk requested a review from roneli December 2, 2021 12:27
Copy link
Contributor

@spangenberg spangenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amanenk and others added 2 commits December 3, 2021 12:04
# Conflicts:
#	CHANGELOG.md
#	resources/migrations/8_v0.7.1.down.sql
#	resources/migrations/8_v0.7.1.up.sql
@roneli roneli merged commit 75c3f00 into cloudquery:main Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Cloudfront Support
4 participants