Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Implement SSM instances and compliance items #299

Merged
merged 7 commits into from
Nov 29, 2021
Merged

Implement SSM instances and compliance items #299

merged 7 commits into from
Nov 29, 2021

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Nov 25, 2021

No description provided.

@irmatov
Copy link
Contributor Author

irmatov commented Nov 25, 2021

it's not clear how to do e2e for this, if at all possible

@irmatov irmatov requested a review from roneli November 25, 2021 08:14
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had one comment regarding adding an ARN.

resources/ssm_instances.go Show resolved Hide resolved
resources/ssm_instances.go Show resolved Hide resolved
@irmatov irmatov requested a review from roneli November 25, 2021 09:02
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a few more comments

resources/ssm_instances.go Outdated Show resolved Hide resolved
resources/ssm_instances.go Outdated Show resolved Hide resolved
@irmatov irmatov requested a review from roneli November 29, 2021 11:36
@roneli roneli merged commit 687d460 into cloudquery:main Nov 29, 2021
@irmatov irmatov deleted the ssm_resource branch November 30, 2021 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants