Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Implement ACM certificates resource #313

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Implement ACM certificates resource #313

merged 5 commits into from
Dec 1, 2021

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Nov 30, 2021

No description provided.

Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some review comments

resources/acm_certificates.go Outdated Show resolved Hide resolved
resources/acm_certificates.go Show resolved Hide resolved
Co-authored-by: Ron <38083777+roneli@users.noreply.github.com>
@irmatov irmatov requested a review from roneli November 30, 2021 12:42
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irmatov
Copy link
Contributor Author

irmatov commented Dec 1, 2021

Added tags

Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit b05293c into cloudquery:main Dec 1, 2021
@irmatov irmatov deleted the acm_resource branch December 1, 2021 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants