Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Fix call to ListAccounts in a non-org user #337

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

spangenberg
Copy link
Contributor

The error might not be IAM policy related and needs to be treated
independent from the rest.

Fixes #254

@spangenberg spangenberg requested a review from roneli December 7, 2021 18:10
@spangenberg spangenberg self-assigned this Dec 7, 2021
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli
Copy link
Contributor

roneli commented Dec 7, 2021

Another option, before I merge this, we can return that error from the resolver keeping the error classifier clean and generic. Wdyt?

@roneli roneli self-requested a review December 7, 2021 19:40
client/errors.go Outdated Show resolved Hide resolved
The error might not be IAM policy related and needs to be treated
independent from the rest.
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass and merge

@spangenberg spangenberg force-pushed the fix/aws-list-accounts-permission-err branch from ab65328 to 5109af5 Compare December 8, 2021 10:57
@spangenberg spangenberg force-pushed the fix/aws-list-accounts-permission-err branch from 5109af5 to eb8f226 Compare December 8, 2021 11:00
@roneli roneli merged commit e34d920 into main Dec 8, 2021
@roneli roneli deleted the fix/aws-list-accounts-permission-err branch December 8, 2021 11:48
roneli pushed a commit that referenced this pull request Dec 15, 2021
Co-authored-by: Kemal Hadimli <disq@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to call ListAccounts in a non-org user
2 participants