Add table identifier length test

CHANGELOG.md

@@ -5,6 +5,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+* Added new test for table and column name limits [#133](https://github.com/cloudquery/cq-provider-sdk/pull/133)
 
 ## [v0.5.5] - 2021-12-15
 

provider/schema/validators.go

@@ -5,9 +5,10 @@ import (
 	"fmt"
 )
 
-const maxTableName = 63
-
-const maxColumnName = 63
+const (
+	maxTableName  = 63 // maximum allowed identifier length is 63 bytes https://www.postgresql.org/docs/13/limits.html
+	maxColumnName = 63
+)
 
 var defaultValidators = []TableValidator{
 	LengthTableValidator{},

provider/testing/resource.go

@@ -66,6 +66,10 @@ func TestResource(t *testing.T, providerCreator func() *provider.Provider, resou
 	require.Nil(t, err)
 
 	testProvider := providerCreator()
+
+	// No need for configuration or db connection, get it out of the way first
+	testTableIdentifiersForProvider(t, testProvider)
+
 	testProvider.Logger = l
 	testProvider.Configure = resource.Configure
 	_, err = testProvider.ConfigureProvider(context.Background(), &cqproto.ConfigureProviderRequest{
@@ -167,3 +171,24 @@ func getTablesFromMainTable(table *schema.Table) []string {
 	}
 	return res
 }
+
+func testTableIdentifiersForProvider(t *testing.T, prov *provider.Provider) {
+	t.Parallel()
+	for _, res := range prov.ResourceMap {
+		res := res
+		t.Run(res.Name, func(t *testing.T) {
+			testTableIdentifiers(t, res)
+		})
+	}
+}
+
+func testTableIdentifiers(t *testing.T, table *schema.Table) {
+	assert.NoError(t, schema.ValidateTable(table))
+
+	for _, res := range table.Relations {
+		res := res
+		t.Run(res.Name, func(t *testing.T) {
+			assert.NoError(t, schema.ValidateTable(res))
+		})
+	}
+}