Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

SDK Improvements #41

Merged
merged 12 commits into from
Jul 4, 2021
Merged

SDK Improvements #41

merged 12 commits into from
Jul 4, 2021

Conversation

roneli
Copy link
Contributor

@roneli roneli commented Jun 24, 2021

  • add support to disable delete
  • move table creation outside of SDK. caller should create tables
  • changed id to cq_id (more readable)
  • add meta field
  • add support for user defined primary keys

- add support to disable delete
- move table creation outside of SDK. caller should create tables
- changed id to cq_id (more readable)
Copy link
Contributor

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a high level view. I will do a more comprehensive test tomorrow.

cqproto/grpc.go Outdated Show resolved Hide resolved
cqproto/internal/plugin.proto Outdated Show resolved Hide resolved
provider/schema/meta.go Outdated Show resolved Hide resolved
provider/schema/resource.go Show resolved Hide resolved
@roneli roneli merged commit f52579f into cloudquery:main Jul 4, 2021
@roneli roneli deleted the feat/sdk_improvements branch August 17, 2021 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants