Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "fix(deps): Update module github.com/schollz/progressbar/v3 to v3.14.3 (#330)" #338

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: Revert "fix(deps): Update module github.com/schollz/progressbar/v3 to v3.14.3 (#330)" #338

merged 1 commit into from
Jun 6, 2024

Conversation

erezrokah
Copy link
Member

This reverts commit cf33df6.

Summary

#330 introduced some regressions in our CLI (see 0)

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt ./... to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@github-actions github-actions bot added the fix label Jun 6, 2024
@erezrokah erezrokah added the automerge Add to automerge PRs once requirements are met label Jun 6, 2024
@erezrokah erezrokah requested a review from disq June 6, 2024 12:36
@kodiakhq kodiakhq bot merged commit 74429d5 into main Jun 6, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the fix/revert_progress_bar branch June 6, 2024 12:40
@cq-bot cq-bot mentioned this pull request Jun 6, 2024
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 6, 2024
@cq-bot
chore(main): Release v1.19.19 (#337)
7ec2a06 
🤖 I have created a release *beep* *boop*
---


## [1.19.19](v1.19.18...v1.19.19) (2024-06-06)


### Bug Fixes

* Progressbar handling ([#336](#336)) ([538487d](538487d))
* Revert "fix(deps): Update module github.com/schollz/progressbar/v3 to v3.14.3 ([#330](#330))" ([#338](#338)) ([74429d5](74429d5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disq disq disq approved these changes

Assignees
No one assigned
Labels
automerge Add to automerge PRs once requirements are met fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezrokah @disq