-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): add go-task support #1608
Conversation
add go-task support Signed-off-by: kovacs <mritd@linux.com>
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
+ Coverage 87.86% 88.15% +0.28%
==========================================
Files 104 104
Lines 8975 8975
==========================================
+ Hits 7886 7912 +26
+ Misses 916 892 -24
+ Partials 173 171 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
build with go-task Signed-off-by: kovacs <mritd@linux.com>
support cross compile Signed-off-by: kovacs <mritd@linux.com>
Waiting for PR #1626 to be merged, remove GCC configuration. |
remove GCC build Signed-off-by: kovacs <mritd@linux.com>
update README Signed-off-by: kovacs <mritd@linux.com>
@HFO4 PR update completed. For the github action I haven't changed (I can't test it), it may need you to modify; By the way, go-task already provides a standard github action installation method: https://taskfile.dev/installation/#github-actions |
Thanks! |
Unfortunately, after detailed tests and estimates, I need to revert this change due to the below considerations:
I will try to use goreleaser to implement the current task flow. |
I don't understand exactly what it affects. For the environment variable, if it is obtained through For the For more complex processing, go-task also supports embedding shell commands to complete. According to my understanding, goreleaser is only a compilation and release tool, and does not have any task scheduling capabilities. For github action publishing, after executing |
What you're describing is "variables" not "environment variables".
This will make the taskfile extremely complicated. The goal is simply: archive binaries to
That would make no improvement compared to original shell script approach.
We don't need task scheduling capabilities in goreleaser since it has all features we needed for packaging Cloudreve.
We still need to archive it to |
add go-task support
Signed-off-by: kovacs mritd@linux.com