Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default skill speak content #1

Open
wants to merge 1 commit into
base: SwordAndGuqin
Choose a base branch
from
Open

add default skill speak content #1

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 5, 2017

No description provided.

Copy link
Owner

@clouds56 clouds56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, and some small issues commented.

@@ -14,6 +14,70 @@ local FORCE_TYPE = {
CHANG_GE = 22, -- 长歌
BA_DAO = 23, -- 霸刀
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One empty line plz

[FORCE_TYPE.CHUN_YANG] = {
[371] = { "hit" }, --[[镇山河]]
[372] = { "hit" }, --[[转乾坤]]
[310] = { "hit", "got" }, --[[剑飞惊天]]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice here only CHUN_YANG would speak when "got" 310, but I think you might want every force to take action when "got" 310.
So remove this or consider have a new FORCE_TYPE like -1 that contains all predefine skills that every one would have.

[2234] = { "casting" }, --[[仙王蛊鼎]]
},
[FORCE_TYPE.TANG_MEN] = {
[3094] = { "hit" }, --[[心无旁骛]]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all others do not have skills like 3094 but only TANG_MEN has?

[258] = { "hit" }, --[[舍身决]]
},
[FORCE_TYPE.WAN_HUA] = {
[139] = { "hit", "casting" }, --[[锋针]]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When comments appears at the end of a line just use -- comments instead of --[[comments]]

@clouds56 clouds56 assigned clouds56 and ghost and unassigned clouds56 Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants