Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Custom dry-run #29

Closed
wants to merge 1 commit into from
Closed

chore: Custom dry-run #29

wants to merge 1 commit into from

Conversation

michaeldowseza
Copy link
Member

@michaeldowseza michaeldowseza commented Oct 29, 2024

Description

Custom dry-run that only builds what is necessary. Re-using the existing dry-run builds a lot more than what is needed and takes the majority of the build time.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (1e827d5) to head (eedcdcb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          19       19           
  Lines         520      520           
  Branches       34       34           
=======================================
  Hits          516      516           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaeldowseza michaeldowseza marked this pull request as ready for review October 29, 2024 09:20
@michaeldowseza michaeldowseza requested a review from a team as a code owner October 29, 2024 09:20
@michaeldowseza michaeldowseza requested review from cansuaa and removed request for a team October 29, 2024 09:20
@michaeldowseza michaeldowseza deleted the dry-run branch October 31, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant