Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds findAll finder to test utils #34

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Nov 19, 2024

Description

Adds two findAll[COMPONENT_NAME]s() test utils selectors to each component wrapper.
Similar to: cloudscape-design/components#3024

Depends on cloudscape-design/test-utils#74

Related links, issue #, if available: Test utils API improvements project

How has this been tested?

✅ Copies including the JSDocs and the pluralizations have been reviewed by the content team.
🧪 Unit tests added to both selectors and dom test utils.

Related links, issue #, if available: Test utils API improvements project

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@orangevolon orangevolon changed the title feat: Adds findAll finder to function feat: Adds findAll finder to test utils Nov 19, 2024
@orangevolon orangevolon force-pushed the feat/adds-find-all-selectors-to-test-utils branch 4 times, most recently from 05fc0d3 to 3e4d382 Compare November 20, 2024 11:41
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (ac996e0) to head (3fbe5ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          19       19           
  Lines         520      520           
  Branches       64       61    -3     
=======================================
  Hits          516      516           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@orangevolon orangevolon force-pushed the feat/adds-find-all-selectors-to-test-utils branch from 3e4d382 to 75e9d58 Compare November 20, 2024 12:28
@orangevolon orangevolon force-pushed the feat/adds-find-all-selectors-to-test-utils branch from 75e9d58 to 646822c Compare November 20, 2024 12:30
@orangevolon orangevolon force-pushed the feat/adds-find-all-selectors-to-test-utils branch from 646822c to 824f246 Compare November 20, 2024 12:47
@orangevolon orangevolon marked this pull request as ready for review November 20, 2024 12:47
@orangevolon orangevolon requested a review from a team as a code owner November 20, 2024 12:47
@orangevolon orangevolon requested review from Al-Dani and removed request for a team November 20, 2024 12:47
@orangevolon orangevolon force-pushed the feat/adds-find-all-selectors-to-test-utils branch from 824f246 to 8142a12 Compare November 20, 2024 12:56
@orangevolon orangevolon force-pushed the feat/adds-find-all-selectors-to-test-utils branch from 8142a12 to 3fbe5ae Compare November 20, 2024 13:51
@orangevolon orangevolon requested review from taheramr and removed request for Al-Dani November 20, 2024 13:53
@@ -0,0 +1,17 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
const pluralizationMap = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking, can we consider in the future to move this list entirely to this package?
https://github.com/cloudscape-design/build-tools

@orangevolon orangevolon added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit aefa6da Nov 20, 2024
39 checks passed
@orangevolon orangevolon deleted the feat/adds-find-all-selectors-to-test-utils branch November 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants