-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds findAll finder to test utils #34
Conversation
05fc0d3
to
3e4d382
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 19 19
Lines 520 520
Branches 64 61 -3
=======================================
Hits 516 516
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
3e4d382
to
75e9d58
Compare
75e9d58
to
646822c
Compare
646822c
to
824f246
Compare
824f246
to
8142a12
Compare
8142a12
to
3fbe5ae
Compare
@@ -0,0 +1,17 @@ | |||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
// SPDX-License-Identifier: Apache-2.0 | |||
const pluralizationMap = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking, can we consider in the future to move this list entirely to this package?
https://github.com/cloudscape-design/build-tools
Description
Adds two
findAll[COMPONENT_NAME]s()
test utils selectors to each component wrapper.Similar to: cloudscape-design/components#3024
Depends on cloudscape-design/test-utils#74
Related links, issue #, if available: Test utils API improvements project
How has this been tested?
✅ Copies including the JSDocs and the pluralizations have been reviewed by the content team.
🧪 Unit tests added to both selectors and dom test utils.
Related links, issue #, if available: Test utils API improvements project
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.