chore: Upgrade lockfiles to version 3 #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Mar 2, 2024
| @@ -4,8 +4,7 @@ | |||
| "version": "0.0.0", | |||
| "type": "module", | |||
| "scripts": { | |||
| "build": "node build.js", | |||
| "preinstall": "node ./unlock-package-lock.cjs" | |||
There was a problem hiding this comment.
This script had no effect, because preinstall actually runs after all modules already installed 🤷
npm/cli#2660
just-boris
force-pushed
the
upgrade-lockfiles
branch
from
7391a87
to
566f40a
Compare
just-boris
commented
Mar 2, 2024
|
|
||
| const lockfiles = [ | ||
| 'package-lock.json', | ||
| 'backstop/package-lock.json', |
There was a problem hiding this comment.
This file does not have dependencies on our components, but I think having an index of all lockfiles in the repository is useful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 669 669
Lines 18114 18114
Branches 6003 6003
=======================================
Hits 17180 17180
Misses 869 869
Partials 65 65 ☔ View full report in Codecov by Sentry. |
YueyingLu
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npm install --lockfile-version 3to convert lockfiles to the latest versionRelated links, issue #, if available: n/a
How has this been tested?
PR build
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.