-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experiment: Refactor funnel implementation #2893
Draft
michaeldowseza
wants to merge
11
commits into
main
Choose a base branch
from
refactor/analytics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldowseza
changed the title
chore: Refactor funnel implementation
experiment: Refactor funnel implementation
Oct 17, 2024
michaeldowseza
force-pushed
the
refactor/analytics
branch
from
October 18, 2024 09:18
e1b9de7
to
59befb7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2893 +/- ##
==========================================
- Coverage 96.21% 95.51% -0.70%
==========================================
Files 761 771 +10
Lines 21490 21625 +135
Branches 7359 7377 +18
==========================================
- Hits 20676 20656 -20
- Misses 761 960 +199
+ Partials 53 9 -44 ☔ View full report in Codecov by Sentry. |
michaeldowseza
force-pushed
the
refactor/analytics
branch
from
November 8, 2024 12:07
c230525
to
f6a3312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This simplifies the existing funnel instrumentation by removing the nested funnel abstraction contexts to define a funnel step and substep and opts for a controller pattern instead where the funnel status is maintained in regular classes.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.