Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: Refactor funnel implementation #2893

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

michaeldowseza
Copy link
Member

@michaeldowseza michaeldowseza commented Oct 17, 2024

Description

This simplifies the existing funnel instrumentation by removing the nested funnel abstraction contexts to define a funnel step and substep and opts for a controller pattern instead where the funnel status is maintained in regular classes.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@michaeldowseza michaeldowseza changed the title chore: Refactor funnel implementation experiment: Refactor funnel implementation Oct 17, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 78.72340% with 120 lines in your changes missing coverage. Please review.

Project coverage is 95.51%. Comparing base (7693793) to head (c230525).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/internal/analytics/funnel/funnel.ts 71.05% 33 Missing ⚠️
src/internal/analytics/funnel/funnel-substep.ts 50.00% 27 Missing ⚠️
src/alert/index.tsx 21.05% 15 Missing ⚠️
src/internal/analytics/funnel/funnel-base.ts 77.77% 12 Missing ⚠️
src/internal/analytics/funnel/funnel-step.ts 82.00% 9 Missing ⚠️
src/wizard/analytics/funnel/index.tsx 73.07% 7 Missing ⚠️
src/form/analytics/funnel/index.tsx 80.00% 6 Missing ⚠️
src/internal/analytics/contexts/funnel-context.tsx 66.66% 5 Missing ⚠️
src/modal/analytics/funnel/index.tsx 90.90% 3 Missing ⚠️
src/form-field/analytics/funnel/index.tsx 90.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2893      +/-   ##
==========================================
- Coverage   96.21%   95.51%   -0.70%     
==========================================
  Files         761      771      +10     
  Lines       21490    21625     +135     
  Branches     7359     7377      +18     
==========================================
- Hits        20676    20656      -20     
- Misses        761      960     +199     
+ Partials       53        9      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant