chore: U test for checking overridden classes #2993
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion css classes for drawers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2993 +/- ##
========================================
Coverage 96.27% 96.27%
========================================
Files 769 769
Lines 21768 21768
Branches 7039 7383 +344
========================================
Hits 20958 20958
+ Misses 802 757 -45
- Partials 8 53 +45 ☔ View full report in Codecov by Sentry. |
georgylobko
requested review from
cansuaa and
just-boris
and removed request for
a team
just-boris
reviewed
Nov 8, 2024
|
|
||
| wrapper.findDrawerTriggerById('global-drawer')!.click(); | ||
|
|
||
| expect(wrapper!.find('[class*="awsui_drawer-close-button"]')).toBeTruthy(); |
There was a problem hiding this comment.
We need to update these tests to include the filename hash as well
just-boris
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a unit test for global drawers to ensure that classes overridden in another package remain as is. The goal of this test is to avoid any unnoticed modifications to these classes.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.