feat: Adds file input type to button group component #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
=======================================
Coverage 96.34% 96.35%
=======================================
Files 780 781 +1
Lines 21927 21950 +23
Branches 7503 7518 +15
=======================================
+ Hits 21126 21150 +24
+ Misses 749 748 -1
Partials 52 52 ☔ View full report in Codecov by Sentry. |
katiegeorge
force-pushed
the
kg/button-group-file-input
branch
from
53f67d8
to
12ad546
Compare
pan-kot
reviewed
Nov 20, 2024
pages/button-group/test.page.tsx
Outdated
| @@ -187,6 +204,7 @@ export default function ButtonGroupPage() { | |||
| ].filter(canRenderItem); | |||
|
|
|||
| const onItemClick: ButtonGroupProps['onItemClick'] = ({ detail }) => { | |||
| console.log(detail); | |||
There was a problem hiding this comment.
Suggested change
| console.log(detail); |
katiegeorge
force-pushed
the
kg/button-group-file-input
branch
from
12ad546
to
2d8d2db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds file-input to the button group component.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.