Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test that unmountContent is called when app layout is unmounted #3040

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

just-boris
Copy link
Member

@just-boris just-boris commented Nov 20, 2024

Description

Make sure this case has a test

Related links, issue #, if available: P165315773

How has this been tested?

This is a test

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris marked this pull request as ready for review November 20, 2024 16:37
@just-boris just-boris requested a review from a team as a code owner November 20, 2024 16:37
@just-boris just-boris requested review from cansuaa and removed request for a team November 20, 2024 16:37
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (035ae6b) to head (7da2bb8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3040   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         779      779           
  Lines       21900    21900           
  Branches     7503     7493   -10     
=======================================
  Hits        21097    21097           
- Misses        751      796   +45     
+ Partials       52        7   -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant