Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes dependencies on React <19 in tests #80

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Feb 5, 2025

Updates:

  • Removed the use of Simulate util from a fixture;
  • Replaced ReactDOM.render() with testing-library render().

Rel: AWSUI-60345

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (bcb5c78) to head (bdc2f36).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files           9        9           
  Lines         319      319           
  Branches       68       68           
=======================================
  Hits          306      306           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan-kot pan-kot requested a review from avinashbot February 5, 2025 16:18
@pan-kot pan-kot marked this pull request as ready for review February 5, 2025 16:18
@pan-kot pan-kot requested a review from a team as a code owner February 5, 2025 16:18
@just-boris just-boris removed the request for review from a team February 6, 2025 10:22
@pan-kot pan-kot added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit dfe5f81 Feb 6, 2025
38 checks passed
@pan-kot pan-kot deleted the chore-react19-compat branch February 6, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants