Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS and dependency version updates #124

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

henrybell
Copy link
Collaborator

This PR brings the version of NodeJS up to the recommended version 18 for GKE (minor image change, to be updated to a nonroot image in a future PR) and Cloud Functions (from EOS version 10). As well as this there are some related dependency version updates, and the addition of the package-lock.json files to ensure that dependency versions are consistent. This change was initiated based on findings from #122.

Copy link
Collaborator

@bgood bgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrybell henrybell merged commit 7aa56ea into master Aug 22, 2023
11 checks passed
@henrybell henrybell deleted the henrybell-node-version branch August 22, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants