Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user-agent string #127

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add user-agent string #127

merged 1 commit into from
Aug 30, 2023

Conversation

henrybell
Copy link
Collaborator

This PR adds a user-agent string to the poller, scaler, and to the Terraform definitions for the two main deployment models (Cloud Functions and GKE).

@henrybell henrybell assigned bgood and davidcueva and unassigned bgood and davidcueva Aug 30, 2023
@henrybell henrybell added the enhancement New feature or request label Aug 30, 2023
bgood
bgood approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@bgood bgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrybell henrybell merged commit 7499779 into master Aug 30, 2023
11 checks passed
@henrybell henrybell deleted the henrybell-user-agent branch August 31, 2023 14:24
@henrybell henrybell restored the henrybell-user-agent branch August 31, 2023 14:29
@henrybell henrybell deleted the henrybell-user-agent branch September 2, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgood bgood bgood approved these changes

@davidcueva davidcueva Awaiting requested review from davidcueva

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrybell @bgood @davidcueva