fix: use a custom service account for Cloud Build #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielm
force-pushed
the
cf-builder
branch
2 times, most recently
from
fb02215
to
43f8895
Compare
bgood
approved these changes
Sep 16, 2024
New projects by default do not give the default compute service account the required roles to run a cloud build. Therefore the cloud functions do not deploy. Update the TF scripts to create a build-sa service account and use that when deploying the Cloud Functions. Also update versions of Terraform modules to the latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New projects by default do not give the default compute service account the required roles to run a cloud build. Therefore the cloud functions do not deploy.
Update the TF scripts to create a build-sa service account and use that when deploying the Cloud Functions.
Also update versions of Terraform modules to the latest