-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typename in header and add DESCRIBE statement #191
Add typename in header and add DESCRIBE statement #191
Conversation
02be833
to
b7e1c8f
Compare
It seems that there is a bug when executing DML without
|
My thought:
|
Now |
FYI: |
Thank you for filing a PR. Let me review this when I have chance (ETA: end of this week). |
@apstndb Just to confirm, is it ok to merge this PR? |
OK! |
Thanks! |
This PR implements both of typename in header and
DESCRIBE
statement.Their implementation have some common components..
Now, column names in verbose mode are multi line. It contains column names with column types.
Header will be printed even if there is no row in the result.
Column type in header also supports DMLs with
THEN RETURN
.There is no change in no
--verbose
mode.Now,
DESCRIBE
statement prints the shape of result set without execution, andDESC
is not valid statement.DESCRIBE
statement also supports DMLs withTHEN RETURN
.DESCRIBE
statement is fully compatible with Cloud Spanner Emulator.Note: This PR unifies existing
ExplainDmlStatement
intoExplainStatement
.resolve #190