This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
Extend TCK with event-sourced model test #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellanz
reviewed
Aug 29, 2020
marcellanz
reviewed
Aug 29, 2020
marcellanz
reviewed
Aug 30, 2020
| // | ||
| message RequestAction { | ||
| oneof action { | ||
| Emit emit = 1; |
There was a problem hiding this comment.
Nice. I've chosen separate service methods for synthetic (model) CRDT tests for which RequestActions are used here. As it increases the TCK model implementation for certain user languages and also you've chosen a this approach here, I'll change that to a "process" service method per CRDT type too.
There was a problem hiding this comment.
Yes, I thought this would be the easiest to implement, and especially since there are tests that want to have multiple actions. And hopefully also easier to change the tests without needing to change the implementation.
pvlugter
force-pushed
the
tck
branch
2 times, most recently
from
97f1063
to
37a4550
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in evolving the TCK, #316.
Moves the testing infrastructure for the TCK to the common testkit, and updates it to use a send/expect style (and closer to the generic testkit that we've discussed).
Adds a model test for event-sourced entities. This model test requires implementing simple event-sourced entities, where the tests send actions to take (emitting events, forwarding, side effects, failing). The TCK determines which tests to run based on which entities/services have been implemented — marking unimplemented tests as pending.
The event-sourced model test has only been implemented for Java support so far. This uncovered one small bug, where side effects were not actually being recorded. I want to look at fixing #375 (comment) and updating the TCK tests to reflect these changes — currently have FIXMEs where the updated state should be returned — before implementing the new tests for other language supports. And then add a state model test for CRDT entities as well.
Event-sourced tests also cover verifying passivation on the language support side (#359) by testing the event-sourced entity protocol directly.