change isinstance AWSHelperFn to inspect class names #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for the internal AWSHelperFn class & its subclasses and troposphere AWSHelperFn class & its subclasses to be used as a value for all property values enabling the use of troposphere.Ref or similar to be used.
markpeek
requested changes
Mar 16, 2020
|
@markpeek would you be able to re-review now? |
|
I just ran into this same issue, with trying to use a As I think about this more, I wonder if awacs needs a reciprocal EDIT |
|
Any updates on getting this (or any other PR that addresses the issue) merged? |
|
Thank you for adding the test and your patience for me getting it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for the internal
awacs.AWSHelperFnclass + subclasses andtroposphere.AWSHelperFnclass + subclasses to be used as a value for all properties enabling the use oftroposphere.Refor similar to be used.Resolves #139.