Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfn2py dies with bool value #45

Closed
pas256 opened this issue Jan 23, 2014 · 2 comments
Closed

cfn2py dies with bool value #45

pas256 opened this issue Jan 23, 2014 · 2 comments

Comments

@pas256
Copy link
Contributor

pas256 commented Jan 23, 2014

Running latest version of cfn2py from master, I am getting the following error:

AclEgressAll = t.add_resource(NetworkAclEntry(
    "AclEgressAll",
    NetworkAclId=Ref(VpcAcl),
    RuleNumber="100",
    Protocol="-1",
Traceback (most recent call last):
  File "./cfn2py", line 227, in <module>
    globals()["do_" + s.lower()](d)
  File "./cfn2py", line 128, in do_resources
    print '    %s=%s,' % (pk, output_value(pv))
  File "./cfn2py", line 179, in output_value
    for fk, fv in v.items():
AttributeError: 'bool' object has no attribute 'items'

from the source JSON

    "AclEgressAll" : {
      "Type" : "AWS::EC2::NetworkAclEntry",
      "Properties" : {
        "CidrBlock" : "0.0.0.0/0",
        "Egress" : true,
        "Protocol" : "-1",
        "RuleAction" : "allow",
        "RuleNumber" : "100",
        "NetworkAclId" : {
          "Ref" : "VpcAcl"
        }
      }
    },

Please let me know if you need more information.

@markpeek
Copy link
Member

Thanks for the bug report. Please try the latest version.

@pas256
Copy link
Contributor Author

pas256 commented Jan 23, 2014

Yes that works. Thanks!

And thank you for the quick turn around too.

Hons pushed a commit to Hons/troposphere that referenced this issue Dec 23, 2014
Hons pushed a commit to Hons/troposphere that referenced this issue Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants