Support for S3 Lifecycle Rule property NoncurrentVersionTransitions #596
Conversation
…nTransition to a set of NoncurrentVersionTransitions. Using same methodology as the deprecation of Transition.
…r "Remove Expired Object Delete Markers"
# Conflicts: # troposphere/s3.py
… removed erroneous code for delete 'object delete marker' which does not appear to be supported in CloudFormation at this point.
| # aws moved from a single transition to a list of them | ||
| # and deprecated 'NoncurrentVersionTransition', so let's | ||
| # just move it to the new property and not annoy the user. | ||
| self.properties['NoncurrentVersionTransitions'] = [ |
There was a problem hiding this comment.
Do you think it's worth adding a warning here to let the user know so they can transition their templates? At some point I'm assuming that Cloudformation will stop accepting the old format, so it might be nice to guide people along.
There was a problem hiding this comment.
This will always generate the new format even if you use the old standard in py. So the output will always be compliant. Given that I don't see a hard wall that someone will hit at some point down the road do we want to actively induce the change in their py code?
If we feel that a warning is the right way to go we can look at that.
There was a problem hiding this comment.
I think a warning may be a good idea, to encourage keeping troposphere as a thin layer above cloudformation.
Having a warning here also allows troposphere to stop supporting the old format and simplify the code base when increasing major version numbers.
There was a problem hiding this comment.
Is there a preferred way to generate warnings in troposphere?
There was a problem hiding this comment.
@SonOfBytes See https://github.com/cloudtools/troposphere/blob/master/troposphere/dynamodb.py#L6 for an example of using warnings. Thanks!
|
Thanks @SonOfBytes ! |
Add support for S3 Lifecycle Rule move from singular NoncurrentVersionTransition to a set of NoncurrentVersionTransitions. Using same methodology as the deprecation of Transition.
Passes formatting, flake, and tests