Completed AWS SAM support #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I have to fix some code style. |
|
Ok that's fixed |
|
Hey @Noah-Huppert, awesome to see this work carried forward. Nice work! :D |
|
Nice job @Noah-Huppert and @dogonthehorizon! Thank you for getting SAM implemented. |
|
When about do you think this will make it into a release? |
|
I'm trying to wrangle a few remaining PR's into master. More than likely I'll do a new release over the weekend. |
|
Awesome - looking forward to the release |
|
Not involved with the project, but maybe talking to this guy would make sense ? https://github.com/capless/sammy |
|
Unfortunately we already added all of the SAM resources so it wouldn't make much sense to redo it again but using a library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dogonthehorizon did almost all the heavy lifting for this one. I fixed the bug mentioned in the previous PR #671.
I did this by adding a
clsargument to theTemplateGenerator._convert_definitionmethod. If theclsargument is provided it will attempt to create an instance of the provided class. If it is not provided then no classes will be made.Then the only place where this
clsargument is provided is in theTemplateGenerator.__init__method when adding resources.All the tests pass but I am suspicious of my fix, it seemed too simple for such and annoying bug.