Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linting of python files #593

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove linting of python files #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ subdirs += $(test_dir)
.PHONY += help-text
.PHONY += lint
.PHONY += lint_fix
.PHONY += lint_python
.PHONY += lint_rust
.PHONY += lint_shell
.PHONY += precommit
Expand Down Expand Up @@ -94,19 +93,13 @@ fix: format lint_fix
# apply formatting fixes to the working directory
format:
cargo fmt --all
python3 -m black .
ruff check . --fix
taplo fmt

help_text:
@rm -rf $(shell ls examples/help-text/*)
cargo xtask generate-help-text --verbose

lint: lint_shell lint_rust lint_python lint_toml

lint_python:
python3 -m black --quiet --check .
ruff check .
lint: lint_shell lint_rust lint_toml

lint_rust:
cargo fmt --all -- --check
Expand All @@ -121,7 +114,6 @@ lint_toml:
# apply linting fixes
lint_fix:
cargo clippy --workspace --all-features --fix --allow-staged --allow-dirty -- -D warnings
python3 -m black .

subdir_action:
@for sd in $(subdirs) ; do \
Expand Down Expand Up @@ -158,10 +150,6 @@ else ifeq ($(os_name),Linux)
else
@echo "Did not install shellcheck"
endif
python3 -m pip install --user --upgrade black yamllint ruff
ifeq ('',$(shell which ruff))
$(error Need to add python packages to your PATH)
endif

test:
RUST_BACKTRACE=1 cargo xtest
Expand Down
Loading