upgraded ruby-net-ldap gem to version 0.15 keeping keepalive changes intact #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follows the spec reference defined in http://guides.rubygems.org/specification-reference/
Queue reads everywhere
Gemspec cleanup
Encode true as xFF
Add contributing guide
Add changes for 0.9.0 for History.rdoc
…orted-capabilities Support querying ActiveDirectory capabilities when searching root dse
0.9.0 Changelog edits
silences gemspec warnings
Make dev dependencies not open ended
…ation Lazy initialize Net::LDAP::Connection's internal socket
Rubocop style fixes
…-inside-brackets fix space inside brackets
…-after-comma fix space after comma
…cated-hash-methods fix deprecated hash methods
Default is to require a trailing comma.
…ing-comma fix trailing commas
…l-proc fix symbol proc
Update Docs: Net::LDAP now requires ruby >= 2
Normalize the encryption parameter passed to the LDAP constructor
Release 0.14.0
patelanuj28
reviewed
Sep 22, 2016
|
|
||
| return pdu unless pdu.result_code == Net::LDAP::ResultCodeSaslBindInProgress | ||
| raise Net::LDAP::SASLChallengeOverflowError, "sasl-challenge overflow" if ((n += 1) > MaxSaslChallenges) | ||
| raise Net::LDAP::SASLChallengeOverflowError, "sasl-challenge overflow" if ((n += 1) > 10) |
There was a problem hiding this comment.
How do you came up with value 10? Isn't that variable "MaxSaslChallenges" used by any other place?
|
This can be merge to appropriate branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
21 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.