test: enrich ut for Default in server/hertz.go #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportBase: 67.53% // Head: 67.50% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #403 +/- ##
===========================================
- Coverage 67.53% 67.50% -0.03%
===========================================
Files 89 89
Lines 8608 8608
===========================================
- Hits 5813 5811 -2
- Misses 2435 2438 +3
+ Partials 360 359 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
li-jin-gou
approved these changes
Nov 24, 2022
Duslia
reviewed
Nov 24, 2022
| resp, err := http.Get("http://127.0.0.1:6669/test") | ||
| assert.NotNil(t, err) | ||
| assert.Nil(t, resp) | ||
| assert.DeepEqual(t, uint32(0), atomic.LoadUint32(&testint)) |
There was a problem hiding this comment.
Should we test panic on the basis of server.New? Because it only has one more middleware than server.new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
test: Adding missing tests or correcting existing tests
Check the PR title.
(Optional) Translate the PR title into Chinese.
为server/hertz.go中的Default 方法添加单元测试
(Optional) More detail description for this PR(en: English/zh: Chinese).
en:
zh(optional):
Which issue(s) this PR fixes:
null