-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support peek multi value for query args #684
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #684 +/- ##
===========================================
+ Coverage 81.82% 81.83% +0.01%
===========================================
Files 98 98
Lines 9926 9932 +6
===========================================
+ Hits 8122 8128 +6
Misses 1314 1314
Partials 490 490
☔ View full report in Codecov by Sentry. |
refer to https://github.com/cloudwego/hertz/pull/569/files and do you have a real world example of this use? |
Do you mean I need to describe this scenario in a test like https://github.com/cloudwego/hertz/pull/569/files#diff-6b0ef71f167bc3e1767a55944dc08d8cfb025629780b5cfcceb1cbe21e668e21R577 ? |
Reference code implementation |
Sorry, I still don't get your point, can you tell me what aspect of PR implementation I need to refer to?
The above is all my guesswork, I'd like some clear advice to let me know what I should do. 🙏 |
ok |
users needs to use this PR and I will CR it today |
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
支持获取多个值的query参数
(Optional) More detail description for this PR(en: English/zh: Chinese).
en:
ctx.Query
cannot get multiple values ofa
froma=1&a=2&b=1
.QueryArray
is provided ingin
to get multiple values, but rfc3986 does not define the implementation of the server, and many frameworks are inconsistent when parsing repeated queries , some only use the first or last occurrence.So I'm not sure it needs to be implemented in
RequestContext
, but I hope there is still a way to get it.zh(optional):
ctx.Query
无法从a=1&a=2&b=1
获取a
的多个值。gin
中提供了QueryArray
获取多个值,但是 rfc3986 没有定义服务端的实现,很多框架在解析的时候不一致,有些只使用第一个值或最后一个值。所以我不确定它是否需要在
RequestContext
中实现,但我希望有办法获到它。Which issue(s) this PR fixes: