Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:add klog examples #84

Merged
merged 6 commits into from
Nov 26, 2023
Merged

docs:add klog examples #84

merged 6 commits into from
Nov 26, 2023

Conversation

ViolaPioggia
Copy link
Member

What type of PR is this?

docs

Check the PR title.

docs:add klog examples

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:dd klog examples
zh(optional): 增加 klog 示例

@ViolaPioggia ViolaPioggia requested review from a team as code owners November 23, 2023 13:00
@li-jin-gou
Copy link
Member

kitex 的 klog 扩展和 otel 目前是耦合的 @rogerogers 用户直接只用 log 用会有问题嘛

@rogerogers
Copy link
Contributor

logrus单独用有点问题,用ctxlogf的几个方法会打印出trace信息。zap有做判断。

go.mod Show resolved Hide resolved
@li-jin-gou li-jin-gou merged commit 0fe3c64 into cloudwego:main Nov 26, 2023
3 checks passed
@ViolaPioggia ViolaPioggia deleted the example branch November 27, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants