Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support thrift and pb multi service #1217

Merged

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners January 5, 2024 06:54
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (10ea358) 68.26% compared to head (c362637) 68.46%.

Files Patch % Lines
pkg/remote/message.go 56.25% 13 Missing and 1 partial ⚠️
server/server.go 83.87% 3 Missing and 2 partials ⚠️
pkg/remote/trans/netpollmux/server_handler.go 90.32% 3 Missing ⚠️
internal/server/register_option.go 71.42% 1 Missing and 1 partial ⚠️
pkg/generic/json_test/generic_init.go 0.00% 1 Missing and 1 partial ⚠️
server/service.go 95.74% 1 Missing and 1 partial ⚠️
pkg/remote/trans/default_server_handler.go 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1217      +/-   ##
===========================================
+ Coverage    68.26%   68.46%   +0.20%     
===========================================
  Files          282      284       +2     
  Lines        20490    20618     +128     
===========================================
+ Hits         13987    14116     +129     
- Misses        5318     5319       +1     
+ Partials      1185     1183       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_multi_service branch from 728858a to 9a717cf Compare January 8, 2024 09:49
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_multi_service branch from b4613ce to 13fc1f1 Compare January 9, 2024 03:31
@Marina-Sakai Marina-Sakai changed the title WIP: feat: support thrift and pb multi service feat: support thrift and pb multi service Jan 9, 2024
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_multi_service branch 2 times, most recently from 56a0c75 to afa76a3 Compare January 11, 2024 09:54
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_multi_service branch 4 times, most recently from 5b4fb56 to 764464e Compare January 22, 2024 08:07
@Marina-Sakai Marina-Sakai force-pushed the feat/thrift_multi_service branch from 5b2d363 to 1110383 Compare January 30, 2024 03:25
felix021
felix021 previously approved these changes Feb 1, 2024
@Marina-Sakai Marina-Sakai merged commit 34b88b2 into cloudwego:develop Feb 1, 2024
18 checks passed
@Marina-Sakai Marina-Sakai deleted the feat/thrift_multi_service branch February 1, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants