-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support thrift and pb multi service #1217
Merged
Marina-Sakai
merged 55 commits into
cloudwego:develop
from
Marina-Sakai:feat/thrift_multi_service
Feb 1, 2024
Merged
feat: support thrift and pb multi service #1217
Marina-Sakai
merged 55 commits into
cloudwego:develop
from
Marina-Sakai:feat/thrift_multi_service
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1217 +/- ##
===========================================
+ Coverage 68.26% 68.46% +0.20%
===========================================
Files 282 284 +2
Lines 20490 20618 +128
===========================================
+ Hits 13987 14116 +129
- Misses 5318 5319 +1
+ Partials 1185 1183 -2 ☔ View full report in Codecov by Sentry. |
728858a
to
9a717cf
Compare
Marina-Sakai
commented
Jan 9, 2024
Marina-Sakai
commented
Jan 9, 2024
b4613ce
to
13fc1f1
Compare
HeyJavaBean
reviewed
Jan 9, 2024
Marina-Sakai
commented
Jan 10, 2024
56a0c75
to
afa76a3
Compare
Marina-Sakai
commented
Jan 12, 2024
jayantxie
reviewed
Jan 15, 2024
jayantxie
reviewed
Jan 15, 2024
jayantxie
reviewed
Jan 15, 2024
jayantxie
reviewed
Jan 15, 2024
YangruiEmma
reviewed
Jan 16, 2024
YangruiEmma
reviewed
Jan 16, 2024
5b4fb56
to
764464e
Compare
jayantxie
reviewed
Jan 23, 2024
jayantxie
reviewed
Jan 23, 2024
jayantxie
reviewed
Jan 23, 2024
jayantxie
reviewed
Jan 23, 2024
jayantxie
reviewed
Jan 23, 2024
jayantxie
reviewed
Jan 23, 2024
5b2d363
to
1110383
Compare
felix021
reviewed
Feb 1, 2024
felix021
previously approved these changes
Feb 1, 2024
felix021
approved these changes
Feb 1, 2024
jayantxie
approved these changes
Feb 1, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: