Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): prioritize BizStatusError in DefaultClientErrorHandler #1253

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

PureWhiteWu
Copy link
Member

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

如果 BizStatusError 存在,优先返回 BizStatusError。

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: If BizStatusError is not nil, it means that the business logic has been processed and the error has been set and transmitted to the client. In this case, just return the bizErr directly.

zh(optional): 如果 BizStatusError 存在,那么必然是 Server 返回回来的,这时可以直接返回这个 BizStatusError。

@PureWhiteWu PureWhiteWu added the enhancement New feature or request label Feb 19, 2024
@PureWhiteWu PureWhiteWu self-assigned this Feb 19, 2024
@PureWhiteWu PureWhiteWu requested review from a team as code owners February 19, 2024 13:04
@PureWhiteWu PureWhiteWu force-pushed the feat/prioritize_biz_status_error branch 2 times, most recently from bc5ccd8 to 480dac3 Compare February 19, 2024 14:05
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff85e39) 68.46% compared to head (b088062) 68.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1253      +/-   ##
===========================================
+ Coverage    68.46%   68.50%   +0.03%     
===========================================
  Files          285      285              
  Lines        20708    20712       +4     
===========================================
+ Hits         14178    14188      +10     
+ Misses        5336     5332       -4     
+ Partials      1194     1192       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PureWhiteWu PureWhiteWu force-pushed the feat/prioritize_biz_status_error branch from 480dac3 to b088062 Compare February 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

1 participant