Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(generic): support an option to remove go.tag annotation #1526

Merged
merged 11 commits into from
Oct 9, 2024
Merged

feat(generic): support an option to remove go.tag annotation #1526

merged 11 commits into from
Oct 9, 2024

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners September 3, 2024 05:52
@Marina-Sakai Marina-Sakai changed the title feat(generic): support an option to remove go.tag annotation WIP: feat(generic): support an option to remove go.tag annotation Sep 3, 2024
AsterDY
AsterDY previously approved these changes Sep 3, 2024
View reviewed changes
@Marina-Sakai Marina-Sakai changed the title WIP: feat(generic): support an option to remove go.tag annotation feat(generic): support an option to remove go.tag annotation Sep 17, 2024
jayantxie
jayantxie previously approved these changes Oct 8, 2024
View reviewed changes
@Marina-Sakai Marina-Sakai merged commit 58c5848 into cloudwego:develop Oct 9, 2024
19 checks passed
@Marina-Sakai Marina-Sakai deleted the feat/remove_go_tag branch October 9, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantxie jayantxie jayantxie approved these changes

@AsterDY AsterDY AsterDY approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marina-Sakai @AsterDY @jayantxie