Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(retry): add configuration to support disable timeout retry when do failure retry, which is for the non-idempotent request #887

Merged

Conversation

YangruiEmma
Copy link
Member

@YangruiEmma YangruiEmma commented Mar 31, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

feat(retry): 增加配置,支持异常重试场景下不对超时做重试,用于请求非幂等的场景

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

Which issue(s) this PR fixes:

@YangruiEmma YangruiEmma requested review from a team as code owners March 31, 2023 08:00
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (7ba0db0) 68.97% compared to head (6058edd) 69.09%.

❗ Current head 6058edd differs from pull request most recent head 40e184d. Consider uploading reports for the commit 40e184d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #887      +/-   ##
===========================================
+ Coverage    68.97%   69.09%   +0.11%     
===========================================
  Files          238      238              
  Lines        17812    17810       -2     
===========================================
+ Hits         12286    12305      +19     
+ Misses        4416     4399      -17     
+ Partials      1110     1106       -4     
Impacted Files Coverage Δ
pkg/retry/failure_retryer.go 88.95% <100.00%> (ø)
pkg/retry/policy.go 95.37% <100.00%> (-0.09%) ⬇️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YangruiEmma YangruiEmma force-pushed the feat/failure_retry_no_timeout branch from 28cadca to e2d764a Compare March 31, 2023 09:10
pkg/retry/policy.go Outdated Show resolved Hide resolved
pkg/retry/policy.go Outdated Show resolved Hide resolved
felix021
felix021 previously approved these changes Mar 31, 2023
@YangruiEmma YangruiEmma merged commit f674603 into cloudwego:develop Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants