Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lazy init pollers to avoid create any poller goroutines if netpoll is not used #306

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

joway
Copy link
Member

@joway joway commented Feb 6, 2024

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat: 懒加载 pollers 以避免在 netpoll 没有被使用时,创建任何 poller goroutines

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

Fixes #305

(optional) The PR that updates user documentation:

@joway joway requested review from a team as code owners February 6, 2024 06:54
@joway joway force-pushed the feat/lazy-init branch 4 times, most recently from 2328507 to 192bafc Compare February 20, 2024 06:25
jayantxie
jayantxie previously approved these changes Feb 20, 2024
@joway joway merged commit 7ba622b into cloudwego:develop Feb 20, 2024
9 checks passed
@joway joway deleted the feat/lazy-init branch February 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Goleaks] Found unexpected goroutines in netpoll error
2 participants