correctly pass 'acl' arg in put_bucket() (closes #172)

cloudyr · Mar 19, 2018 · 168f359 · 168f359
1 parent 61a265c
commit 168f359
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -2,6 +2,7 @@
 
 * Fixed a bug in `s3write_using()`. (#205, h/t Patrick Miller)
 * Bumped **aws.signature** dependency to v0.3.7 to take advantage of automatic credential loading. (#184, h/t Dan Tenenbaum)
+* `acl` argument was ignored by `put_bucket()`. This is now fixed. (#172)
 
 # aws.s3 0.3.8
 

diff --git a/R/put_bucket.R b/R/put_bucket.R
@@ -30,7 +30,9 @@ function(bucket,
          ...){
     b <- paste0('<CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><LocationConstraint>', 
                 region, '</LocationConstraint></CreateBucketConfiguration>')
-    r <- s3HTTP(verb = "PUT", 
+    acl <- match.arg(acl)
+    headers <- c(list(`x-amz-acl` = acl), headers)
+    ir <- s3HTTP(verb = "PUT", 
                 bucket = bucket,
                 request_body = b,
                 headers = headers,