Fix gcs_copy_object() to use bucketLevel permissions

[MarkEdmondson1234]

@MarkEdmondson1234 Thanks for the Hotfix. But i Think you missed the gcs_copy_object() function. There should also be a parametervalue "bucketLevel". I tried it with the latest github commit, but it didn't work. and it says

Request Status Code: 400
Error: API returned: Invalid string value: 'bucketLevel'. Allowed values: [authenticatedread, bucketownerfullcontrol, bucketownerread, private, projectprivate, publicread]

As long as the update isn't available in CRAN. Can you please post a snippet which removes the ACLs from the call to get this work?

Originally posted by @Pit-Storm in #111 (comment)

[MarkEdmondson1234]

@Pit-Storm best tracked in a new issue

It will involve adding a blank ACL object as shown in this commit 37f922c to the gcs_copy_object() code:

googleCloudStorageR/R/objects.R

Lines 378 to 422 in 276fe3a

	gcs_copy_object <- function(source_object,
	destination_object,
	source_bucket = gcs_get_global_bucket(),
	destination_bucket = gcs_get_global_bucket(),
	rewriteToken = NULL,
	destinationPredefinedAcl = NULL){
	assert_that(
	is.string(source_object),
	is.string(destination_object)
	)
	source_gcs <- gcs_parse_gsurls(source_object)
	if(!is.null(source_gcs)){
	source_object <- source_gcs$obj
	source_bucket <- source_gcs$bucket
	}
	destination_gcs <- gcs_parse_gsurls(destination_object)
	if(!is.null(destination_gcs)){
	destination_object <- destination_gcs$obj
	destination_bucket <- destination_gcs$bucket
	}
	source_bucket <- as.bucket_name(source_bucket)
	destination_bucket <- as.bucket_name(destination_bucket)
	source_object <- URLencode(source_object, reserved = TRUE)
	destination_object <- URLencode(destination_object, reserved = TRUE)
	the_url <- sprintf("https://www.googleapis.com/storage/v1/b/%s/o/%s/rewriteTo/b/%s/o/%s",
	source_bucket, source_object, destination_bucket, destination_object)
	pars <- NULL
	if(!is.null(rewriteToken)){
	pars <- list(rewriteToken = rewriteToken)
	}
	if(!is.null(destinationPredefinedAcl)){
	assert_that(is.string(destinationPredefinedAcl))
	pars <- c(pars, list(destinationPredefinedAcl = destinationPredefinedAcl))
	}
	ob <- gar_api_generator(the_url,
	"POST",
	pars_args = pars,
	data_parse_function = function(x) x)
	ob()
	}

[MarkEdmondson1234]

@Pit-Storm what example code are you using to trigger your error? From the looks of it not specifying the ACL should respect that existing objects ACL level.

[Pit-Storm]

I fixed it by setting predefinedACL to NULL. Aren't you think that this is little inconvenient with respect to the upload function? Kind reagrds 26. Oktober 2020 11:26, "Mark" <notifications@github.com (mailto:notifications@github.com?to=%22Mark%22%20<notifications@github.com>)> schrieb: @Pit-Storm (https://github.com/Pit-Storm) what example code are you using to trigger your error? From the looks of it not specifying the ACL should respect that existing objects ACL level. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (#132 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AIBQ47XUB2G4SPH2SHHJKXDSMVFEDANCNFSM4S7FTZXQ).

[MarkEdmondson1234]

I'm a bit confused as the default is NULL. May I ask for the example code you used and the sessionInfo(), it could be that its just fixed on GitHub?

[Pit-Storm]

I think I made some missunderstandable comments. In the first place, I used predefinedACL="bucketLevel" because I knew the setting from the upload object. I wasn't trying without the predefinedACL parameter. After it didn't work, I checked the docs for it. There wasn't any bucketLevel or NULL setting for this parameter mentioned. For this reason i opend the ticket. After that, I saw that there had been a discussion on that and your suggestion to set the ACL to NULL when doing the call. So I tried predefinedACL=NULL. I didn't check the dfault setting. As far as I can see that issue it is a peace about docs and a peace about convenient parameter settings. In my eyes it is a little confusing why one has to be set the predefinedACL on the upload function explicitly if the bucketLevelACLs are enabled and on the other side one is able to use a default parameter setting with the copy function. But I'm not sure if I missunderstood something in general. Kind regards PS: I'm not able to provide a full working code example for now, because I'm not at my work machine.

[MarkEdmondson1234]

Makes sense, yes it can be changed to be more consistent.