Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enter out of block quote's #171

Open
Tracked by #169 ...
cloverich opened this issue May 28, 2024 · 0 comments
Open
Tracked by #169 ...

Cannot enter out of block quote's #171

cloverich opened this issue May 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cloverich
Copy link
Owner

cloverich commented May 28, 2024

  • Create a block quote and type some text
  • Try to use enter to escape out of it

Enter should escape out of it, while shift+enter should remain within it. This behavior should be implemented by the createResetNode plugin:

        createResetNodePlugin({
          options: {
            rules: [
              {
                types: [ELEMENT_BLOCKQUOTE, ELEMENT_TODO_LI],
                defaultType: ELEMENT_PARAGRAPH,
                hotkey: "Enter",
                predicate: isSelectionAtBlockEnd,
              }

But this does not seem to work, and after some basic debugging I do not understand why. :(

Old description

I previously had this description as below, but I must have indavertantly fixed this at some point; I can easilyi use the "turn into' / toggle block menu to change out of a block quote.

  • Create element
  • Turn into quote
  • Turn into another element -- it will still be indented like quote

You can kind of turn things into and out of quotes, but its stuck indented. You also cannot backspace to escape block formatting and return to a default (presumably paragraph). Probably some plugin addition / tweaking to support this all properly, and definitely related to / or maybe same thing as #85

But stands out more after implementing the #103 which allowed toggling blocks (etc).

@cloverich cloverich added the bug Something isn't working label May 28, 2024
@cloverich cloverich changed the title Cannot escape quote Cannot enter out of block quote's Aug 24, 2024
@cloverich cloverich mentioned this issue Aug 24, 2024
23 tasks
@cloverich cloverich mentioned this issue Sep 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant