pagination #115
Merged
pagination #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloverich
force-pushed
the
cursor-pagination
branch
from
ecbc73b to
6ce40ba
Compare
cloverich
commented
Jan 18, 2024
| export class SearchV2Store { | ||
| @observable docs: SearchItem[] = []; | ||
| @observable loading = true; | ||
| @observable error: string | null = null; | ||
| private journals: JournalsStore; | ||
| private tagSeachStore: TagSearchStore; | ||
| private setTokensUrl: any; // todo: This is react-router-dom's setUrl; type it | ||
| setTokensUrl: any; // todo: This is react-router-dom's setUrl; type it |
There was a problem hiding this comment.
Ideally not public, but needs re-set on re-render from the UI.
cloverich
commented
Jan 18, 2024
| this.journals = journals; | ||
| this.tagSeachStore = new TagSearchStore(this); | ||
| this.setTokensUrl = setTokensUrl; | ||
|
|
||
| // Re-run the search query anytime the tokens change. | ||
| reaction(() => this._tokens.slice(), this.search, { |
There was a problem hiding this comment.
I invariably end up replacing reactions with imperative code. Reaction always feels more elegant, but @action and @computed and @observable alone are usually easier to reason about.
- support before:<uuid> to page off of note uuids (which sort by time) - add next and back buttons utilizing before:<uuid> - some refactoring to support this
cloverich
force-pushed
the
cursor-pagination
branch
from
6ce40ba to
b43ab31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add limit and offset pagination using
before:<uuid>. Closes #34 and the last feature work in #69 😮Behavior implemented:
before:There are some complicating factors in how react router re-renders when the query params change; this seems to behave reasonably, but there's likely more optimization (both performance and conceptual overhead) to be found.
Not pretty but functional. Deferring design to the post-functional design hackathon I'll inevitably do. Deferring a more elegant pagination solution similarly; additional use cases will better guide the refactor. Lack of functional testing library is starting to really hurt.