handle file links, fix web links, security #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow drag and dropping files into the editor. Copy files to user files directory, then render a link to them. Clicking the link opens the file in finder - fix issue where web links were opening in new Electron windows; ensure they open in the system browser instead - refactor link clicking to avoid catching click events in renderer; handle entirely in main process on navigation request instead - add security fixes for directory traversal and in-app link browsing
cloverich
force-pushed
the
file-links
branch
from
51a4101 to
9cf7b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shell.openExternalfunction #51)The main index.js file is spaghetti but reasonably well commented; I think better if all functions are externalized, and the main file handles only attaching listeners at the appropriate times; should make it easier to understand at a glance and to browse.
Was unable to update the
registerFileHandler(deprecated) because after doing so, video's would not seek (but would otherwise work). Will open follow up issue with implementation I tried.