wip: test preload files #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wip commit for testing preload files with electron-mocha. I think the test build is correct, but it wont run with regular mocha because the node version differs beween eletron and local node. I could rebuild for test vs dev but would be slow and maybe fragile constantly going back and forth. One alternative is to use electrons version of node; you can do this but need to then call mocha and do some electron setup; this is what elecgtron-mocha does. But as of this commit its not working -- it doesnt find the test files for one reason or another (outputs 0 tests ran).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip commit for testing preload files with electron-mocha. I think the test build is correct, but it wont run with regular mocha because the node version differs beween eletron and local node. I could rebuild for test vs dev but would be slow and maybe fragile constantly going back and forth. One alternative is to use electrons version of node; you can do this but need to then call mocha and do some electron setup; this is what elecgtron-mocha does. But as of this commit its not working -- it doesnt find the test files for one reason or another (outputs 0 tests ran).
Some other changes:
Parking as WIP until I have a solid chunk of time to dig in further.
Closes #183