sync document crud with search #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-work document create, update, and delete operations to be (mostly) synchronized with search, such that navigating back to the documents list after create / edit / delete reflects the changes in search results. - When creatnig a document, auto-save it and navigate to edit view, adding to current search - When editing, update the document (title, etc) so its reflected in search - When deleting, remove the document from the search results Also re-work document creation to be fully separate from EditableDocument, and remove hack that hid the fact that (technically) stores could be null when pulled from context; updated all calls to append ! so its documented what is happening; hoepfully this protects against future refactors where consumers are yanked out of the provider that sets up the context.
cloverich
force-pushed
the
nav_search_sync
branch
from
cfc94c1 to
e938931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-work document create, update, and delete operations to be (mostly) synchronized with search, such that navigating back to the documents list after create / edit / delete reflects the changes in search results.
Also re-work document creation to be fully separate from EditableDocument, and remove hack that hid the fact that (technically) stores could be null when pulled from context; updated all calls to append ! so its documented what is happening; hopefully this protects against future refactors where consumers are yanked out of the provider that sets up the context.
Closes #170
Closes #189